Repository navigation
Dispatch preferencesChanged WebKit calls to the main thread - #565
Merged
Merged
Conversation
PBWebHistoryController's preferencesChanged touched WebView's windowScriptObject synchronously from whatever thread posted NSUserDefaultsDidChangeNotification. WebKit requires windowScriptObject to be accessed only on the main thread and raises WebKitThreadingException otherwise, crashing the process. - Wrap the script call in dispatch_async(dispatch_get_main_queue()) - Found via the new GitXTests unit-test target: XCTest's bootstrap registers NSUserDefaults from a background thread during process startup, crashing GitX consistently - Unrelated to issue gitx#563 (duplicate commits race)
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PBWebHistoryController's preferencesChanged touched WebView's windowScriptObject synchronously from whatever thread posted NSUserDefaultsDidChangeNotification. WebKit requires windowScriptObject to be accessed only on the main thread and raises WebKitThreadingException otherwise, crashing the process.
Changes
Test plan