Repository navigation
Fix sidebar-refresh to respond to manual refreshes and external branch changes - #562
Merged
Merged
Conversation
goneng
marked this pull request as draft
August 9, 2026 09:24
goneng
changed the title
…h changes The sidebar's checked-out branch checkmark does not update after a branch change made outside GitX (e.g. `git switch` in a terminal), or even after clicking GitX's own manual Refresh button, even though the commit-list header already updates correctly in both cases. reloadRefs already invalidates the cached HEAD ref and fires KVO on refs on every refresh cycle, automatic or manual, but PBGitSidebarController never observed that property. Observe refs in PBGitSidebarController and reload the outline view, preserving the current selection, so the checkmark badge is recomputed against the current HEAD whenever refs change, regardless of what triggered the refresh.
goneng
force-pushed
the
fix-sidebar-refresh
branch
from
August 9, 2026 11:22
d8f7688 to
6e92c1a
Compare
goneng
marked this pull request as ready for review
August 9, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git switchin a terminal) or even after clicking GitX's own manual Refresh button, even though the commit-list header updated correctly.reloadRefsalready invalidates the repository's cached HEAD ref and fires KVO onrefson every refresh cycle, automatic or manual —PBGitSidebarControllerjust wasn't listening to it.PBGitSidebarControllernow observes the repository's existingrefsproperty, reloading the outline view (preserving the current selection) so the checkmark badge is recomputed against the current HEAD whenever refs change, regardless of what triggered the refresh.Also fixes #404.
Test plan
git switchto a different local branch. Confirm the sidebar checkmark moves within ~1-2s without disturbing the current sidebar selection.