Skip to content

Implement a Dark theme for syntaxhighlighter and blame - #390

Merged
hannesa2 merged 1 commit into
gitx:masterfrom
ADTC:#356-source-blame-dark
Mar 12, 2023
Merged

hannesa2 merged 1 commit into
gitx:masterfrom
ADTC:#356-source-blame-dark

Conversation

@ADTC

@ADTC ADTC commented Mar 11, 2023 •

Copy link
Copy Markdown
Contributor

The SH dark theme is the same as the following file, with formatting and minor modifications: Resources/html/lib/syntaxhighlighter/styles/shThemeFadeToGrey.css

Fixes #356

It takes care of the source code and blame views. Unfortunately I don't know how to apply dark background on MGScopeBar so for now I'm keeping it a draft. @hannesa2 please help with the bar. How do we make it have a dark background?

Screenshots:

Soucre:
image

Blame:
image

The SH dark theme is the same as the following file, with formatting and minor modifications:
Resources/html/lib/syntaxhighlighter/styles/shThemeFadeToGrey.css

Fixes gitx#356
@ADTC
ADTC marked this pull request as ready for review March 11, 2023 16:03
@ADTC

ADTC commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

@hannesa2 I did a bit of digging and I'm now convinced that the bar itself will have to be fixed in https://github.com/gitx/MGScopeBar project.

image

Since it's outside the scope of this main project, this pull request is now ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS Ventura (13.x) dark mode, some menu text needs color fix

2 participants