Repository navigation
Change CI artifact to dmg - #256
Conversation
|
Nice 👍 Unfortunately, I downloaded 13.2.1 artifact, but it was not able to start |
|
At least my M1 can't start it. Does it start on your side ? |
|
Yes, it does. I'm not on an M1, though. |
|
There have been issues w/ GitX linking to missing openssl libraries in the past. For a while I had to keep my own local homebrew install of Here's what I'm seeing locally: So maybe |
|
But an older gitx build for x86 is able to start. Only this one doesn't start. I've to check it on my old x86 Mac |
| - name: pre build | ||
| run: cd External/objective-git && script/bootstrap && script/update_libgit2 && cd ../.. | ||
| - name: Build project | ||
| run: xcodebuild -workspace GitX.xcworkspace -scheme GitX -archivePath ./GitX archive |
There was a problem hiding this comment.
Does it maybe help when you add archive ARCHS="x86_64 arm64" ?
There was a problem hiding this comment.
I just pushed this. If it builds, let me know if it helps.
There was a problem hiding this comment.
It also feels curious that #234 (the M1 support PR) also has a lot of openssl related issues.
There was a problem hiding this comment.
It finished, but I don't think it did anything:
Command line invocation:
/Applications/Xcode_13.2.1.app/Contents/Developer/usr/bin/xcodebuild -workspace GitX.xcworkspace -scheme GitX -archivePath ./GitX archive "ARCHS=x86_64 arm64"
User defaults from command line:
IDEArchivePathOverride = /Users/runner/work/gitx/gitx/GitX
IDEPackageSupportUseBuiltinSCM = YES
Build settings from command line:
ARCHS = x86_64 arm64
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:x86_64, id:4203018E-580F-C1B5-9525-B745CECA79EB }
I don't see any other reference to arm64. 😕
|
What do you get when you do |
As expected with arm64 brew it's not there
For arm64 it's located at |
|
Unfortunately it looks like a x86-only-build. This is x86 |
|
At least on my x86 Mac it works properly. Thank you ! |
|
Unfortunately it removes the pressure for other developers to fix the build. But thank you for this nice and necessary contribution. |
This changes the CI artifact from a
.xcarchivedirectory to.dmgthat contains a workingGitX.app. I'm not sure what I was running into yesterday when it seemed like the.xcarchivewas important. I suspect that it had to do w/ the artifact upload CI workflow losing some Mac specific info from some files, but that's just a guess.I went deep into using
xcodebuildto export an app directly from the.xcarchive, but that appears to require developer certificates, signing, etc, so I abandoned that and went back to study how it's done by UTM (which I'm not familiar with and have never used, but which was shared by @hannesa2). They have apackage_mac.shscript running in CI that has a pretty clear "unsigned" code path, and produces a dmg containing a.app. The relevant parts of this PR are just lifted from that.Notes
.zipto a.dmg. A zip gets extracted to a working.appw/o any need to mount/unmount a dmg. I find that simpler, but this isn't super important to me, as long as it works for other folks.GitX-Xcode_13.2.1toGitX build by Xcode_13.2.1, but I'm fine to change it back if others prefer that.