Repository navigation
Conversation
Member
Author
|
Release build based on this PR, for those willing to trust me, or desperate enough to do so: |
Contributor
|
A: Binary B: Own build on M1
but I run into What I'm missing ? |
|
Really appreciate you making this work on M1. I tried the binary, but I'm getting and error: This may be due to the fact that I have installed Homebrew only my current user in a different location. E.g. |
By default yes, but a supported configuration method is to install it at another location. This is especially useful if you have multiple users and you don't want to install globally https://docs.brew.sh/Installation#untar-anywhere |
Contributor
|
Maybe you need this ? |
Member
Author
|
@hannesa2 huh I wonder if I have a cached build somehow. I originally made the change bumping the minimum from 10.8 to 10.9; but after cleaning the build and removing that change I was still able to build. I think we can finally drop support for 10.8... Do a pull and try again. |
Member
Author
|
@felixpalmer We're already having trouble supporting the two canonical locations for brew, let alone custom. I wish I knew how to support whatever the default location was in an agnostic manner. Typically brew --prefix is what you want, but that's only usable in scripts. It won't work everywhere in Xcode, I'm guessing. |
Contributor
|
1: I did a
2: Run this two commands 3: I run into this
|
Member
Author
|
Be sure you have updated the sub modules. I fixed that in the other PR. Or it looks like the same issue I had. |
|
In case you want to do without homebrew, this script which I made for pygit2, will compile Universal builds of openssl, libssh2 and libgit2 on a CI host - which I guess you could probably ... bundle into your ObjectiveGit framework? ...somehow? Like I said, I don't enjoy Xcode, I just hack things into place.... |
Contributor
I did this, that's why I post the output of Nothing to do In which issue did you run into ? |
Member
Author
|
@hannesa2 double-check that you have the right SHAs and have done a pull in both. Also clean your Xcode DerivedData folder. The missing ARM calls in the static linking is what I had fixed and saw in your comment. |
Member
Author
|
@hannesa2 It looks like you have my remote, but definitely double-check. It's a sketchy PR to have a submodule referring to a SHA in a fork of another PR :-) |
Member
Author
|
@hannesa2 You may need to run |
Member
Author
|
I'm working on objective-git's PR, we gotta get the CI build working somehow, then get universal working, then we can get universal working in this PR. |
Contributor
I use your remote I did Maybe you can run this on your side too ? |
Contributor
|
@jspiro I will do the same on my second M1 |
Contributor
Same error on my second M1. (I use a M1 and a M1 PRO) |
|
I am also getting a linker error (M1 Pro) The |
Member
Author
|
I'm using the build that @jspiro provided and it works like a charm on my M1! Perhaps this repository could start publishing the built GitX.app in releases, given that the other published builds are all very out of date. And perhaps the double surprise is that this is the Jono I went to school together!? 😉 |
Member
Author
Awesome! Is your M1 setup from an Intel backup or a clean M1 install? Trying to ensure this will run on vanilla M1s out of the box. That said, the right approach is a universal binary... as soon as I can figure out how to produce one...
Haha, indeed! 👋🏻 Hiya! It's almost like GitHub should form some kind of social network based on what schools you want to and you would have a wall of contributions, and you can post patches on other people's walls. Glad you're a GitXer! |
Mine is from an Intel backup, but I see this app is already Apple Silicon without Intel?
Now that GitHub and LinkedIn are both under the same umbrella who knows when that will happen? 😜 Have been using GitX for years, tried all the other open-source alternatives but never found one that is as intuitive. Thank you (and the other devs, of course) for getting this back on track! |
Contributor
I can confirm the arm64 build works like a charm. But unfortunately nobody (@tcurdt and I) can reproduce this arm64 build locally from @jspiro If there is someone else who can build this pull request local on his M1 please answer in this pull request. |
Member
Author
|
I can't work on this again yet. Still recovering and have log4j to deal with. Use my build for now and we'll get this going again later in the month. |
Contributor
|
This is currently my local issue on M1
But I continue here
to not spam this repo with my tests |
Merged
Contributor
|
Ahh, I see you used |
Contributor
|
I applied all changes to recent master and we are able to build with x86 too, but when I try build local on my M1
@jspiro @ronaldtse @felixpalmer @tcurdt |
Contributor
|
After this #273 the recent master looks like this on my M1
|
Collaborator
|
I don't have an M1 to test, but that looks like the same error as #239 (comment). That boiled down to |
Contributor
|
YES !
This made it work
It's not beautiful to specify exactly |
Contributor
|
It builds now locally with a M1 #275 |
This was referenced Feb 14, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Objective-Git is linked to a branch: gitx/objective-git#15
Partially fixes #204.