Skip to content

Github CI - #208

Merged
hannesa2 merged 8 commits into
masterfrom
Github-CI
Jan 28, 2021
Merged

hannesa2 merged 8 commits into
masterfrom
Github-CI

Conversation

@hannesa2

@hannesa2 hannesa2 commented Jan 26, 2021 •

Copy link
Copy Markdown
Contributor

Before I included more changes, to have less warnings and errors.
But I guess it's better first to build current state and after this to improve it

@hannesa2 hannesa2 mentioned this pull request Jan 26, 2021
@hannesa2

Copy link
Copy Markdown
Contributor Author

@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

Screenshot 2021-01-26 at 12 20 32 AM

haha

Comment thread .github/workflows/BuildPR.yml Resolved
Comment thread .github/workflows/BuildPR.yml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: PullRequest
name: build-gitx

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

You'll also want to update the readme with this badge after you rename the action, e.g.: https://github.com/gitx/gitx/workflows/build-gitx/badge.svg

@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

Pushed the README update. That's it for me for tonight, good luck and have a great day!

@hannesa2

Copy link
Copy Markdown
Contributor Author

I changed this
image

to get rid of
image

Other wise we can only do pull request one-after-the-other or introduce ugly and pointless merge-master-to-branch-commits

@hannesa2

Copy link
Copy Markdown
Contributor Author

How to solve this ?

image

I guess it's on our side, am I right ?

image

@jspiro

jspiro commented Jan 27, 2021

Copy link
Copy Markdown
Member
$ find . -name verify.c
./External/objective-git/External/openssl/apps/verify.c
./External/Sparkle/Vendor/ed25519/src/verify.c

My guess is the submodules are not fully cloned, or that Sparkle removed/renamed this file in the SHA you moved the submodule to. Did we need to change Sparkle?

@jspiro

jspiro commented Jan 27, 2021

Copy link
Copy Markdown
Member
$ rm -rf External/Sparkle
$ git submodule update --init --recursive
Submodule path 'External/Sparkle': checked out 'd5b0804b4a659ccb78c02acf56576fb08ce5d4d7'
Submodule path 'External/Sparkle/Vendor/ed25519': checked out '7fa6712ef5d581a6981ec2b08ee623314cd1d1c4'
$ find . -name verify.c
./External/objective-git/External/openssl/apps/verify.c
./External/Sparkle/Vendor/ed25519/src/verify.c

Seems like it's still there. So must be an incomplete clone.

@hannesa2
hannesa2 force-pushed the Github-CI branch 2 times, most recently from ec0d03f to a10aa51 Compare January 27, 2021 07:54
@hannesa2

hannesa2 commented Jan 27, 2021 •

Copy link
Copy Markdown
Contributor Author

I found the reason https://github.com/sparkle-project/Sparkle/tree/d5222353e6d6ee7baf4c18711e5b897fe2ed886a/Vendor Sparkle comes with this commit with own submodules , that's why we need a recursive submodule checkout

All other pull requests and improvements should now base on pull request !

@hannesa2

Copy link
Copy Markdown
Contributor Author

I removed Travis because of build errors https://travis-ci.org/github/gitx/gitx/builds/756379732

Comment thread README.markdown Resolved

@jspiro jspiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other remnants of travis that we need to remove?

@hannesa2

Copy link
Copy Markdown
Contributor Author

Are there any other remnants of travis that we need to remove?

Cool, you found more. Currently no more are known to me

@hannesa2
hannesa2 merged commit d639b67 into master Jan 28, 2021
@hannesa2
hannesa2 deleted the Github-CI branch January 28, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants