Repository navigation
build.py: Remove argh dependency - #107
Merged
Merged
Conversation
Contributor
|
Nice, thanks ! |
goneng
added a commit
to goneng/gitx
that referenced
this pull request
Sep 21, 2026
Every GitX build runs libgit2's cmake build, which compiled a Clar test suite that is never run, because the flag meant to switch it off stopped matching libgit2's own option name at the 1.x rename. - Move the objective-git pointer onto gitx/objective-git#108, which passes -DBUILD_TESTS:BOOL=OFF in place of the dead -DBUILD_CLAR:BOOL=OFF and cuts 471 of the 667 objects the build compiles. - Take that fix alone rather than the current objective-git master, which has since moved on to unrelated work in gitx#107.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the build setup by removing external python dependencies. It eliminates this common problem: https://github.com/gitx/gitx/wiki/Build-instructions#no-module-named-argh
The functionality of the script remains the same. We replace
arghwith python's ownargparse. And sinceargcompleteisn't used anywhere, we can also removerequirements.txt../Scripts/build.py build debug,./Scripts/build.py build release,./Scripts/build.py config debugand./Scripts/build.py config release, all work.