Skip to content

Enhance: Allow choosing a light or dark appearance instead of following the system #714

Closed

Description

@goneng

GitX takes its appearance entirely from System Settings. NSAppearance+PBDarkMode only ever reads effectiveAppearance, nothing sets NSApp.appearance, and no preference or menu item exists for it, so there is no way to keep GitX light while the rest of the Mac is dark, or the other way round.

Asked for in #662 (comment).

Proposal: a three-way setting - System (the default), Light, Dark - stored as a preference and offered both in Settings > General and as a View > Appearance submenu.

Setting NSApp.appearance is the mechanism, with nil meaning "follow the system". That cascades to every window, sheet and web view, and it updates effectiveAppearance, so the existing PBEffectiveAppearanceChanged plumbing and every consumer of it keep working unchanged. The legacy WebView resolves prefers-color-scheme from its effectiveAppearance too, so the blame and fileview stylesheets follow the override as well.

Activity

  1. self-assigned this
    on Sep 22, 2026
  2. added a commit that references this issue on Sep 23, 2026
  3. changed the title [-]Allow choosing a light or dark appearance instead of following the system[/-] [+]Enhance: Allow choosing a light or dark appearance instead of following the system[/+] on Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions