Skip to content

Double click changes branch, but don't update right side #606

Closed

Description

@hannesa2

@goneng
it's related to new 1.5.6, in 1.5.5 it wasn't there

Image

Activity

  1. added theissue type on Sep 12, 2026
  2. hannesa2 commented on Sep 12, 2026

    @hannesa2
    ContributorAuthor

    Looks like #582 causes this

  3. hannesa2 commented on Sep 12, 2026

    @hannesa2
    ContributorAuthor

    It's a pain to have no good test coverage and when you work with a fork, then is there no artifact to test.
    That's why I invited you, then you can work direct with upstream repo and there will be artifacts in pull requests
    @goneng

  4. goneng commented on Sep 12, 2026

    @goneng
    Collaborator

    @hannesa2, looks like it selects the correct line on the right pane, but does not scroll to it when it is out of view.

  5. goneng commented on Sep 12, 2026

    @goneng
    Collaborator

    @hannesa2, OK - Reproduced: the list does move to the new branch's tip, but the rebuild that follows the checkout resets the scroll back to the top while restoring the selection in place, so the right commit ends up selected off-screen;
    it comes from #579 rather than #582, and the fix is up as #612.

  6. goneng commented on Sep 12, 2026

    @goneng
    Collaborator

    It's a pain to have no good test coverage and when you work with a fork, then is there no artifact to test. That's why I invited you, then you can work direct with upstream repo and there will be artifacts in pull requests @goneng

    @hannesa2, we are adding tests as we go... (I guess I've missed this bug because I usually keep my branches short and close to main, so it is rare that their tip-commits are off-screen)

  7. hannesa2 commented on Sep 12, 2026

    @hannesa2
    ContributorAuthor
  8. goneng commented on Sep 12, 2026

    @goneng
    Collaborator

    That's why I invited you

    Accepted, thanks! - I'll push (new) branches here so the CI artifacts are there to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions