Skip to content

External "git" is still called multiple times for the same staged file #530

Open

Description

@SMA-HP

It seems when staging a single file, the external "git" command is called multiple times with same parameter fast in sequence:

Image

The expectation is that the command is only called once, but not multiple times.

I'll debug this issues...

Activity

  1. SMA-HP commented on Mar 7, 2026

    @SMA-HP
    CollaboratorAuthor

    I found first issue of this: #531
    But there is still more... I'll check....

  2. hannesa2 commented on Mar 7, 2026

    @hannesa2
    Contributor

    Great, then I wait for a new release ....

  3. goneng commented on Sep 7, 2026

    @goneng
    Collaborator

    Is this now solved with https://github.com/gitx/gitx/releases/tag/1.4 ?

    Partly fixed.
    The cause SMA-HP found in #531 has been fixed since 1.4, and the follow-ups
    (refresh race, update-index on every FSEvents notification, coalescing overlapping refreshes)
    all shipped in 1.5.5, so the process storm is gone and that release is worth testing.

    Measured on 1.5.5: staging one file runs update-index once plus two index refresh rounds,
    and repeating it gives identical counts, so nothing accumulates any more.

    What is left is the command in the screenshot above.
    diff-files -U3 for the selected file still runs 3 times per stage, down from 9,
    because Resources/html/views/commit/commit.js re-asks for the diff on
    every re-render of the commit view with no caching.
    Selecting a file without staging costs exactly 1.

    Happy to track that separately if you would rather close this one.

  4. added a commit that references this issue on Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions