You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
MacOS Ventura (13.x) dark mode, some menu text needs color fix #356
I couldn't find this by searching for "Tree View" or tree mode so here it is in a comment. I concur that the Source file list and blame are still light. History is dark, but the bar above is light (with white fonts).
Oh no, @hannesa2 I just got some free time and started looking into this. I think we should remove MGScopeBar and replace it with PBGitGradientBarView instead. We already use this for the bar with buttons for AllLocal and the search box. It works correctly with Light vs. Dark mode changes and looks almost the same as MGScopeBar.
Thanks for the merge though. I'll just make the above into another PR (if I can get it working).
Update: Unfortunately Objective-C is still magic to me, and demystifying it will take me some time.
Activity
mavwolverine commentedon Nov 21, 2022
The 'Source', 'Blame' and 'History' menu is hard to read
hannesa2 commentedon Nov 21, 2022
Thanks for your report. We also need some helping hands with pull request
mavwolverine commentedon Nov 23, 2022
@hannesa2 would have loved to help, but its been 10 years since I have touched ObjC :(
ADTC commentedon Feb 25, 2023
I couldn't find this by searching for "Tree View" or tree mode so here it is in a comment. I concur that the Source file list and blame are still light. History is dark, but the bar above is light (with white fonts).
Implement a Dark theme for syntaxhighlighter and blame
ADTC commentedon Mar 11, 2023
@hannesa2 I have the pull request with a nice dark theme :)
Unfortunately the bar will have to be fixed in the submodule https://github.com/gitx/MGScopeBar project. I haven't figured out how, and ObjC isn't something I'm familiar with. Hope someone with ObjC experience can help fix the bar itself. (But I may hack something up to see if I can make it work.)
Merge pull request #390 from ADTC/#356-source-blame-dark
ADTC commentedon Mar 12, 2023
Oh no, @hannesa2 I just got some free time and started looking into this. I think we should remove
MGScopeBarand replace it withPBGitGradientBarViewinstead. We already use this for the bar with buttons forAllLocaland the search box. It works correctly with Light vs. Dark mode changes and looks almost the same asMGScopeBar.Thanks for the merge though. I'll just make the above into another PR (if I can get it working).
Update: Unfortunately Objective-C is still magic to me, and demystifying it will take me some time.