Skip to content

NSAssert after series of "git mv" #106

Closed

Description

@vng
  • Build latest master
  • Open any repository
  • Make series of "git mv" commands for any files and folders
  • NSAssert1 in PBGitIndex.m, (NSMutableDictionary *)dictionaryForLines:(NSArray *)lines

lines contains last non-paired element with some numeric value ("10" in my case)
git version 2.15.1

Activity

  1. vng commented on Dec 15, 2017

    @vng
    ContributorAuthor

    Moreover, if you have more than 30 files in modified, deleted or created, "Unstaged changes" list view becomes bugging. It doesn't show more changes until stage some of them ... Seems like this bug is connected with topic's header NSAssert.

  2. added a commit that references this issue on Feb 5, 2018
  3. tiennou commented on Feb 5, 2018

    @tiennou
    Contributor

    Well, #106 is not #102, sorry about that @vng. Your 2nd comment is the 2nd part of #102, but I have seen the first one too, and IIRC it's related sometimes ending up with incorrectly ordered data/calls when refreshing the index (I know it's easy to get a confused representation). I'll try to investigate what happens when git mv things around.

  4. vng commented on Feb 5, 2018

    @vng
    ContributorAuthor

    Good. At least your #9a69e976684f79a1ad812c937d585028ab29f404 fix makes master more robust.
    And your solution is definitely better than mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions