@@ -112,8 +112,8 @@ var setSelectHandlers = function()
112112 if ( file . id = "selected" )
113113 file = file . parentNode ;
114114 var start = target ;
115- var elem_class = start . getAttribute ( "class" ) ;
116- if ( ! elem_class || ! ( elem_class == "addline" | elem_class == "delline" ) )
115+ var elemClasses = start . classList ;
116+ if ( ! ( elemClasses . contains ( "addline" ) || elemClasses . contains ( "delline" ) ) )
117117 return false ;
118118 deselect ( ) ;
119119 var bounds = findsubhunk ( start ) ;
@@ -122,11 +122,11 @@ var setSelectHandlers = function()
122122 } ;
123123
124124 file . onmousedown = function ( event ) {
125- if ( event . which != 1 )
125+ if ( event . which != 1 )
126126 return false ;
127- var elem_class = event . target . getAttribute ( "class" )
127+ var elemClasses = event . target . classList ;
128128 event . stopPropagation ( ) ;
129- if ( elem_class == "hunkheader" || elem_class == "hunkbutton" )
129+ if ( elemClasses . contains ( "hunkheader" ) || elemClasses . contains ( "hunkbutton" ) )
130130 return false ;
131131
132132 var target = findParentElementByTag ( event . target , "div" ) ;
@@ -202,11 +202,26 @@ var displayDiff = function(diff, cached)
202202
203203 for ( i = 0 ; i < hunkHeaders . length ; ++ i ) {
204204 var header = hunkHeaders [ i ] ;
205- if ( cached )
206- header . innerHTML = "<a href='#' class='hunkbutton' onclick='addHunk(this, true); return false'>Unstage</a>" + header . innerHTML ;
205+ if ( cached ) {
206+ header . innerHTML = "<a href='#' class='hunkbutton unstage-button'>Unstage</a>" + header . innerHTML ;
207+ header . getElementsByClassName ( 'unstage-button' ) [ 0 ] . addEventListener ( "click" , function ( e ) {
208+ e . preventDefault ( ) ;
209+ addHunk ( this , true ) ;
210+ } ) ;
211+ }
207212 else {
208- header . innerHTML = "<a href='#' class='hunkbutton' onclick='discardHunk(this, event); return false'>Discard</a>" + header . innerHTML ;
209- header . innerHTML = "<a href='#' class='hunkbutton' onclick='addHunk(this, false); return false'>Stage</a>" + header . innerHTML ;
213+ header . innerHTML =
214+ "<a href='#' class='hunkbutton add-hunk-button'>Stage</a>" +
215+ "<a href='#' class='hunkbutton discard-hunk-button'>Discard</a>" +
216+ header . innerHTML ;
217+ header . getElementsByClassName ( "add-hunk-button" ) [ 0 ] . addEventListener ( "click" , function ( e ) {
218+ e . preventDefault ( ) ;
219+ addHunk ( this , false ) ;
220+ } ) ;
221+ header . getElementsByClassName ( "discard-hunk-button" ) [ 0 ] . addEventListener ( "click" , function ( e ) {
222+ e . preventDefault ( ) ;
223+ discardHunk ( this , event ) ;
224+ } ) ;
210225 }
211226 }
212227 setSelectHandlers ( ) ;
@@ -275,19 +290,19 @@ var discardHunk = function(hunk, event)
275290
276291/* Find all contiguous add/del lines. A quick way to select "just this
277292 * chunk". */
278- var findsubhunk = function ( start ) {
279- var findBound = function ( direction ) {
293+ var findsubhunk = function ( start ) {
294+ var findBound = function ( direction ) {
280295 var element = start ;
281- for ( var next = element [ direction ] ; next ; next = next [ direction ] ) {
282- var elem_class = next . getAttribute ( "class" ) ;
283- if ( elem_class == "hunkheader" || elem_class == "noopline" )
284- break ;
296+ for ( var next = element [ direction ] ; next ; next = next [ direction ] ) {
297+ var elemClasses = next . classList ;
298+ if ( elemClasses . contains ( "hunkheader" ) || elemClasses . contains ( "noopline" ) )
299+ break ;
285300 element = next ;
286301 }
287- return element ;
288- }
289- return [ findBound ( "previousSibling" ) , findBound ( "nextSibling" ) ] ;
290- }
302+ return element ;
303+ }
304+ return [ findBound ( "previousSibling" ) , findBound ( "nextSibling" ) ] ;
305+ }
291306
292307/* Remove existing selection */
293308var deselect = function ( ) {
@@ -306,11 +321,10 @@ var stageLines = function(reverse) {
306321 if ( ! selection ) return false ;
307322 currentSelection = false ;
308323 var hunkHeader = false ;
309- var preselect = 0 , elem_class ;
324+ var preselect = 0 ;
310325
311326 for ( var next = selection . previousSibling ; next ; next = next . previousSibling ) {
312- elem_class = next . getAttribute ( "class" ) ;
313- if ( elem_class == "hunkheader" ) {
327+ if ( next . classList . contains ( "hunkheader" ) ) {
314328 hunkHeader = next . lastChild . data ;
315329 break ;
316330 }
@@ -395,13 +409,13 @@ var computeSelection = function(list, from, to)
395409 insel = true ;
396410 }
397411
398- var elem_class = elem . getAttribute ( "class" ) ;
399- if ( elem_class ) {
400- if ( elem_class == "hunkheader" ) {
412+ var elemClasses = elem . classList ;
413+ if ( elem . className ) {
414+ if ( elemClasses . contains ( "hunkheader" ) ) {
401415 elem = last ;
402416 break ; // Stay inside this hunk
403417 }
404- if ( ! good && ( elem_class == "addline" || elem_class == "delline" ) )
418+ if ( ! good && ( elemClasses . contains ( "addline" ) || elemClasses . contains ( "delline" ) ) )
405419 good = true ; // A good selection
406420 }
407421 if ( elem == to ) break ;
@@ -489,10 +503,14 @@ var showSelection = function(file, from, to, trust)
489503 buttons_div . appendChild ( copy_button ) ;
490504
491505 if ( sel . good ) {
492- button . setAttribute ( 'onclick' , 'stageLines(' +
493- ( originalCached ?'true' :'false' ) +
494- '); return false;' ) ;
495- copy_button . setAttribute ( 'onclick' , 'copy(); return false;' ) ;
506+ button . addEventListener ( "click" , function ( e ) {
507+ e . preventDefault ( ) ;
508+ stageLines ( originalCached ) ;
509+ } ) ;
510+ copy_button . addEventListener ( "click" , function ( e ) {
511+ e . preventDefault ( ) ;
512+ copy ( ) ;
513+ } ) ;
496514 } else {
497515 button . setAttribute ( "class" , "disabled" ) ;
498516 copy_button . setAttribute ( "class" , "disabled" ) ;
0 commit comments