Repository navigation
Commit 062c8f1
committed
Stop the ref labels reading low in their capsules (issue #679)
A ref label's capsule is the text's line box, which reserves room for
an ascender and a descender that most branch names never both use, so
the glyphs sat low in it and a name ending in a descender came to rest
on the capsule's border with nothing underneath it.
* Lift the text a point inside the capsule rather than drawing it into
the capsule itself. That balances the space above the glyphs against
the space below and gives a descender its clearance, without the
capsule changing size at all.
* Leave the capsule alone. Padding it was the first attempt and it is
the wrong remedy: it preserves the ratio of air above the glyphs to
air below and merely adds more of both, which reads worse.
* Cover the lift with tests, one of which pins the capsule's height so
that the padding does not get tried a second time.
Leave the baseline where it is. The labels sit on cap-height centring,
which is what keeps master and MASTER sharing a baseline rather than
drifting apart from one another.1 parent 11ca47b commit 062c8f1
2 files changed
Lines changed: 53 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
259 | 272 | | |
260 | 273 | | |
261 | 274 | | |
| |||
269 | 282 | | |
270 | 283 | | |
271 | 284 | | |
272 | | - | |
| 285 | + | |
| 286 | + | |
273 | 287 | | |
274 | 288 | | |
275 | 289 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
113 | 115 | | |
114 | 116 | | |
115 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
116 | 154 | | |
0 commit comments