Skip to content

Introduce CI - #2

Merged
hannesa2 merged 1 commit into
gitx:masterfrom
hannesa2:CI
Jan 26, 2021
Merged

hannesa2 merged 1 commit into
gitx:masterfrom
hannesa2:CI

Conversation

@hannesa2

@hannesa2 hannesa2 commented Jan 25, 2021 •

Copy link
Copy Markdown

My plan it to introduce in each submodule CI first, and then in https://github.com/gitx/gitx

This is a pre-task to switch to target 10.9

@hannesa2

Copy link
Copy Markdown
Author

Here is builds hannesa2#1 unfortunately in upstream not.
When I would be able to push to upstream, it would build here as well with first commit. So we have to wait, till it's merged

@jspiro Do you have access to settings here ?
@tiennou Here I'm not a maintainer. Anyway, I hope someone will see this pull request

Any improvements are welcome ! I just begin to work with Xcode

@hannesa2

hannesa2 commented Jan 25, 2021 •

Copy link
Copy Markdown
Author

Puhh, everyone make a new fork of a fork of a fork ...

image

Do we need the changes of https://github.com/chbeer/MGScopeBar.git as well ?

@tiennou

tiennou commented Jan 25, 2021

Copy link
Copy Markdown

I've fixed up the permission at the org-level, so you should have access now.

@jspiro jspiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's shockingly straightforward! Once this works for PRs, should we make a workflow for this too when we prepare a release, or have this also do a build upon merge (where are the artifacts stored?)?

Comment thread .github/workflows/BuildPR.yml Resolved
@@ -0,0 +1,25 @@
name: PullRequest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: PullRequest
name: build-mgscopebar

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With it, copy&paste needs some more work in the future 😉

Comment thread .github/workflows/BuildPR.yml Resolved
@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

I've enabled branch protection – after merge, please enable the requirement for this check to succeed: https://github.com/gitx/MGScopeBar/settings/branch_protection_rules/19113317

@hannesa2

Copy link
Copy Markdown
Author

should we make a workflow for this too when we prepare a release, or have this also do a build upon merge (where are the artifacts stored?)?

I would make a workflow for a release (if required) but first I want to have the pull request flow done

@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

should we make a workflow for this too when we prepare a release, or have this also do a build upon merge (where are the artifacts stored?)?

I would make a workflow for a release (if required) but first I want to have the pull request flow

Of course, of course. After!

project: MGScopeBar.xcodeproj
scheme: MGScopeBar
configuration: Release
action: archive

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is archive or is build better ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archive seems like a good idea, as it packages it up?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check. Are there tests as well to run ?
Sorry, I don't now how to find it in Xcode. Maybe you tell it me

@hannesa2

Copy link
Copy Markdown
Author

Ok, I applied renames

@hannesa2
hannesa2 merged commit e4109e2 into gitx:master Jan 26, 2021
@hannesa2

Copy link
Copy Markdown
Author

Ahhh, sorry, there is something happen with origin and upstream
Rename commit is not on master

image

I will fix it

@hannesa2

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants