update converter for Canonical Name to UULE parameter #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the conversion of Canonical Names to UULE parameters by switching from the previous logic to a protobuf-based encoding/decoding mechanism.
- Replaces the old get_location_id function with a new convert_canonical_name_to_uule and adds dedicated encode/decode functions using protobuf.
- Updates the demo script’s data directory path and bumps dependency versions in the project configuration files.
Reviewed Changes
| File | Description |
|---|---|
| WebSearcher/locations.py | Refactors UULE generation by removing get_location_id and adding protobuf encode/decode. |
| scripts/demo_locations.py | Changes the data directory from 'data/locations' to 'data/google_locations'. |
| pyproject.toml | Increments version and updates the protobuf dependency requirement. |
| WebSearcher/init.py | Updates the version string to match the new release. |
| WebSearcher/searchers.py | Adjusts usage to call the new convert_canonical_name_to_uule function for UULE parameters. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for converting Canonical Names to UULE parameters was incorrect for a subset of newer Canonical Names. Now using
protobufto encode/decode, see this gist for details on the changes and which locations might have been affected.