Group .gitignore entries by purpose#1758
Merged
Byron merged 1 commit intogitpython-developers:mainfrom Dec 5, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's sort of subjective whether, once
.gitignorefiles become long, they should be grouped. The intention seemed roughly to group it, and I think this may be preferred to sorting it or doing neither.This divides the entries into groups and labels each group with a comment.
I've also included some minor changes, which can be omitted if desired (I can amend and force push or commit again):
/*.egg-infobecause/*egg-infocovers it.__pycache__/even though it should probably only contain*.pycand*.pyo.monkeytype.sqlite3.*for compressed copies of that database. In #1725 I was tempted to removetest/tstrunner.py, but I'm glad I didn't, because it looks like MonkeyType may still be useful for next time work is done on improving type annotations. Actually, what seems most useful to me about it is that it detects cases where imports rewrite what modules are accessible where, causing a situation wherefrom x.y import zimportszfrom a differentythanimport x.yorfrom x import yimports. Anyway, the sqlite database it outputs is about 2.2 GiB, but compresses down to about 27 MiB (whenxzis used). So I think it makes sense to ignore such files, too, to make working with them easier.