Skip to content

chore: update french translations#408

Merged
housseindjirdeh merged 1 commit into
gitpoint:masterfrom
machour:french-update
Oct 2, 2017
Merged

chore: update french translations#408
housseindjirdeh merged 1 commit into
gitpoint:masterfrom
machour:french-update

Conversation

@machour

@machour machour commented Oct 2, 2017

Copy link
Copy Markdown
Member

Translated english strings.

Other languages still need to be updated!

housseindjirdeh
housseindjirdeh approved these changes Oct 2, 2017
View reviewed changes

@housseindjirdeh housseindjirdeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you.

If this is all that's left, we might be able to get away with Google Translate for these short strings?

@housseindjirdeh housseindjirdeh merged commit 8252d59 into gitpoint:master Oct 2, 2017
@machour

machour commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

@abdurrahmanekr @anaskhan96 @RolfKoenders @arthurdenner

Can you guys help us with those small translations?

  • markAllAsRead: 'Mark all as read
  • commentActions: 'Comment Actions'
  • editCommentTitle: 'Edit Comment'
  • editAction: 'Edit'
  • deleteAction: 'Delete'

Please reply to this comment with the 5 translations in your language, I'll make sure they get merged in. Otherwise we'll have to rely on Google Translate and might not be really accurate.

Thanks in advance !

@machour machour deleted the french-update branch October 2, 2017 10:34
@abdurrahmanekr

abdurrahmanekr commented Oct 2, 2017

Copy link
Copy Markdown
Contributor

Turkish Translations:

  • markAllAsRead: 'Hepsini okundu olarak işaretle'
  • commentActions: 'Yorum Hareketleri'
  • editCommentTitle: 'Yorumu Düzenle'
  • editAction: 'Düzenle'
  • deleteAction: 'Sil'

@machour machour mentioned this pull request Oct 2, 2017
Merged
@jouderianjr

jouderianjr commented Oct 2, 2017

Copy link
Copy Markdown
Member

Hey @machour was missing only one key in pt-br, just created the PR

@machour

machour commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

@abdurrahmanekr Thank you so much! Sorry I missed a few other strings 🙏

  connectingToGitHub: 'Connecting to GitHub...',
  preparingGitPoint: 'Preparing GitPoint...',
  cancel: 'CANCEL',

@abdurrahmanekr

abdurrahmanekr commented Oct 2, 2017

Copy link
Copy Markdown
Contributor
  • connectingToGitHub: 'GitHub'a Bağlanılıyor...',
  • preparingGitPoint: 'GitPoint Hazırlanıyor...',
  • cancel: 'İPTAL'
    👍

@machour

machour commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

Thank you again @abdurrahmanekr !

@abdurrahmanekr abdurrahmanekr mentioned this pull request Oct 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@machour @abdurrahmanekr @jouderianjr @housseindjirdeh