Config min version#1955
Merged
Merged
Conversation
rgmz
approved these changes
Oct 15, 2025
|
|
||
| // extend minVersion | ||
| if validateMinVersion(extensionConfig.MinVersion) != nil { | ||
| // fail here? |
bplaxco
reviewed
Oct 15, 2025
Comment on lines
+430
to
+433
| } | ||
| if extensionConfig.MinVersion != "" { | ||
| c.MinVersion = extensionConfig.MinVersion | ||
| } |
Contributor
There was a problem hiding this comment.
So this basically bumps the min version to the highest1 min version out of this and the extended config? (or chain of them if they chain, I can't remember if you can chain config extensions).
Footnotes
-
Because it'd fail if the min version of the parent config was set and the extension config was lower, correct? ↩
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduces a minversion check that users can define in the config. The default config will ship w/ v8.25.0.
Checklist: