Skip to content

feat: add artifactory reference token and api key detection#1906

Merged
zricethezav merged 3 commits into
gitleaks:masterfrom
cgoessen:feat/artifactory
Jul 8, 2025
Merged

feat: add artifactory reference token and api key detection#1906
zricethezav merged 3 commits into
gitleaks:masterfrom
cgoessen:feat/artifactory

Conversation

@cgoessen
Copy link
Copy Markdown
Contributor

@cgoessen cgoessen commented Jul 3, 2025

Description:

Explain the purpose of the PR.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

Copy link
Copy Markdown
Contributor

@rgmz rgmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition! I have a couple suggestions to improve the filtering of false-positives.

Comment thread cmd/generate/config/rules/artifactory.go Outdated
Comment thread cmd/generate/config/rules/artifactory.go Outdated
Comment thread cmd/generate/config/rules/artifactory.go Outdated
Comment thread cmd/generate/config/rules/artifactory.go Outdated
@zricethezav
Copy link
Copy Markdown
Collaborator

thank you @cgoessen and @rgmz for the review 🙇🏻

@zricethezav zricethezav merged commit a044b81 into gitleaks:master Jul 8, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants