Reduce aws-access-token false positives#1876
Merged
Merged
Conversation
AWS Access Key IDs are [base32 encoded][1] so the numerical values here will [only be 2-7][2] [1]: https://medium.com/@TalBeerySec/a-short-note-on-aws-key-id-f88cc4317489 [2]: https://en.wikipedia.org/wiki/Base32#Base_32_Encoding_with_Extended_Hex_Alphabet_per_%C2%A77:~:text=It%20uses%20an%20alphabet%20of%20A%E2%80%93Z%2C%20followed%20by%202%E2%80%937
Summary: - Add `config/gitleaks.toml` make target - Make it a dep of `build` and `test` - Update CONTRIBUTING.md to reference the new target Reason: Makes dev easier because you can just tweak the code and run `make test` without an extra step.
```
$ golangci-lint run cmd/
cmd/diagnostics.go:128:10: Error return value of `f.Close` is not checked (errcheck)
f.Close()
^
cmd/diagnostics.go:191:10: Error return value of `f.Close` is not checked (errcheck)
f.Close()
^
2 issues:
* errcheck: 2
```
zricethezav
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adjust aws-access-token regex
AWS Access Key IDs are base32 encoded so the numerical values here will only be 2-7
Update config/gitleaks.toml during build and test
Summary:
config/gitleaks.tomlmake targetbuildandtestReason: Makes dev easier because you can just tweak the code and run
make testwithout an extra step.Resolve lint issues in cmd/diagnostics.go
Checklist: