Skip to content

Fix rule-specific allowlist paths not working#1845

Merged
zricethezav merged 1 commit into
gitleaks:masterfrom
rgmz:fix/allowlist-path-eval
Apr 30, 2025
Merged

Fix rule-specific allowlist paths not working#1845
zricethezav merged 1 commit into
gitleaks:masterfrom
rgmz:fix/allowlist-path-eval

Conversation

@rgmz
Copy link
Copy Markdown
Contributor

@rgmz rgmz commented Apr 30, 2025

Description:

Fixes #1844. Doing return caused the function to potentially exit before testing all allowlists. An oversight on my part.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav
Copy link
Copy Markdown
Collaborator

excellent catch. ty for test

@zricethezav zricethezav merged commit d1c7759 into gitleaks:master Apr 30, 2025
2 checks passed
@rgmz rgmz deleted the fix/allowlist-path-eval branch April 30, 2025 15:40
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule-specific allowlist paths not working with extend useDefault = true

2 participants