Fix config validate rules when [extend] is used#1592
Merged
Conversation
Closed
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
aa4833b to
644e906
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
644e906 to
3f2eacd
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
3 times, most recently
from
9918042 to
e4011f6
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
3 times, most recently
from
9e02138 to
2935f5a
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
2935f5a to
e448be7
Compare
Contributor
Author
|
@zricethezav Thoughts? |
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
e448be7 to
07e0c09
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
07e0c09 to
bdc9335
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
bdc9335 to
a16dbea
Compare
rgmz
force-pushed
the
fix/config-rule-validate
branch
from
a16dbea to
44b4f43
Compare
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fixes an issue where rules were not being validated when the config contained
[extend]. This closes #1590.Because
extendDepthis globally mutable,if extendDepth == 0 {was never true.Checklist: