Fix E2E smoke test hanging when GitHub VPN is active#5100
Merged
nikolay-1986 merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Uses a non-GitHub remote URL in the smoke test fixture to prevent GitLens from attempting GitHub integration network calls (getDefaultBranch GraphQL query) during tree loading. The GitHub GraphQL client has no request timeout — with VPN blocking api.github.com, the call hangs until the OS TCP timeout (~75s), keeping the grouped view in loading state indefinitely and causing the Commits view assertion to time out. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
🤖 Augment PR SummarySummary: Updates the E2E smoke test fixture to use a non-GitHub remote URL so GitLens doesn’t attempt background GitHub integration connections during tests. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running E2E smoke tests with an active VPN, the test would hang for several seconds. The root cause was that the fake remote URL used
github.comas the host, causing GitLens to attempt to connect to the GitHub integration in the background — resulting in network timeouts.Fix
Changed the fake remote URL in the smoke test fixture from
https://github.com/test/test-repo.gittohttps://example.com/test/test-repo.git. Using a non-GitHub host prevents GitLens from triggering any GitHub integration connection attempts during testing.Changes
tests/e2e/specs/smoke.test.ts— replaced fake remote URL host withexample.com