branch names with special characters '<' also causes errors on the co… …mmand line like #2028#2030
Merged
eamodio merged 4 commits intogitkraken:mainfrom Jun 13, 2022
Merged
branch names with special characters '<' also causes errors on the co… …mmand line like #2028#2030eamodio merged 4 commits intogitkraken:mainfrom
eamodio merged 4 commits intogitkraken:mainfrom
Conversation
eamodio
requested changes
Jun 11, 2022
Member
eamodio
left a comment
eamodio
left a comment
There was a problem hiding this comment.
Thanks for the report and contribution!
The changes in src/env/node/git/git.ts aren't needed -- since they are valid branch names, just the change in repository.ts is required.
Author
Okay |
Member
|
So if you want to undo that change, and just leave the |
…mand line modify src/env/node/git/git.ts
Author
sorry i forgot to undo it |
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
branch names with special characters '<' also causes errors on the co…
…mmand line like #2028
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses