Closes #1787 - Remove '-review' from reviewDomain()#1788
Closed
Levistator wants to merge 1 commit intogitkraken:mainfrom
Closed
Closes #1787 - Remove '-review' from reviewDomain()#1788Levistator wants to merge 1 commit intogitkraken:mainfrom
Levistator wants to merge 1 commit intogitkraken:mainfrom
Conversation
Was breaking integration with my installation of gerrit. Why should the subdomain be assumed to be anything other than what was directly defined in the settings.json
Contributor
|
I believe #1954 also fixes your problem. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses