Skip to content

fix card color on Welcome view for some themes #5021

@sergeibbb

Description

@sergeibbb

This is a follow-up of gitkraken/vscode-gitlens-private#81

We use following colors for the view background and for the card background:

  • --color-view-background
  • --vscode-textBlockQuote-background

However, on some themes they are the same color.

I want to build the card background based on --vscode-descriptionForeground that is always contrast to the background. For example a card can have a semitransparent color, or maybe it should be even some mix of --vscode-descriptionForeground and --color-view-background.

Fixed in 47d0652

Before:

Image

After:

Image
welcome-all-themes.mp4

Metadata

Metadata

Assignees

Labels

pending-releaseResolved but not yet released to the stable editionverified ✔Verified

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions