CMake: Allow version to be explicitly set without requiring git #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main CMakeLists.txt was updated to allow explicitly setting the version for the project by setting the `ADS_VERSION` variable (e.g. cmake .. -DADS_VERSION=1.0.0). The default behavior is to determine the version by reading the information from git. Adding the option to override this variable at configure time allows the library to be built outside of its git repository, such as when the code is vendored directly into another project and added using `add_subdirectory`.
Owner
|
Thank you for your contribution |
luelista
pushed a commit
to luelista/Qt-Advanced-Docking-System
that referenced
this pull request
Mar 22, 2022
…ubuser0xFFFF#384) The main CMakeLists.txt was updated to allow explicitly setting the version for the project by setting the `ADS_VERSION` variable (e.g. cmake .. -DADS_VERSION=1.0.0). The default behavior is to determine the version by reading the information from git. Adding the option to override this variable at configure time allows the library to be built outside of its git repository, such as when the code is vendored directly into another project and added using `add_subdirectory`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main CMakeLists.txt was updated to allow explicitly setting the
version for the project by setting the
ADS_VERSIONvariable (e.g.cmake .. -DADS_VERSION=1.0.0).
The default behavior is to determine the version by reading the
information from git. Adding the option to override this variable at
configure time allows the library to be built outside of its git
repository, such as when the code is vendored directly into another
project and added using
add_subdirectory.See #352