Fix issue 380 #383
Merged
Fix issue 380 #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k supposed to fix memory leaks: now leaks were fixed in CDockManager (githubuser0xFFFF#307), the code from dockindock ends up deleting objects already deleted by parent.
Author
|
Not sure I handled branches and updates correctly, I see some merges stuff in the pull request. Not always obvious to follow changes/branches. If it looks wrong, just reject the Pull request. I will do abranc dnew fork from scratch and redo the changes, they are easy because very isolated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed (see #380), I added hideManagerAndFloatingWidgets() function. Changes are clean and isolated (no impact unless hideManagerAndFloatingWidgets() is explicitely called).
Also added and example using hideManagerAndFloatingWidgets().
I have no capability to test Linux. If it fails to compile, I'll blindly fix it.