-
Notifications
You must be signed in to change notification settings - Fork 663
Add maximize button to FloatingWidgetTitleBar [Revived] #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
githubuser0xFFFF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested the changes on linux and it works great - thank you. Please have a look into my review comments.
|
Added the function docstrings. While at it i realized there is a problem where maximized state isn't detected when restoring a state. Also there is no way currently to disable maximizing. I think a global setting for this might make sense .? |
|
I do not see a reason to disable maximizing - so I do not think a configuration flag is required |
|
I could see a point in not allowing resizing at all, but will ignore this for now. I stumbled upon another (but related) problem though. The current maximizing code ignores taskbar and co since At least on my system some offset for a top panel on my desktop seem to be enforced BUT the size isn't affected. This leads to the height being off by about 60 px on my system. |
|
Thats the reason it is not implemented yet - it looks so easy but it isn't 😜 Just tell me if you fixed all issues and your pull request is ready. |
|
Yeah i was not aware how limited X11 is in this regard. If you are talking about your 2 requested changes: These are in the last commit. Personally i don't think this should be merged yet because it simply might "cut" content due to the described bug. I will definitely keep working on this, but can do so in another PR if you feel that's the better approach. |
|
Ok, then create a new pull request if you feel that it is ready |
This is a copy of #61
I did rebase it on the current master, fixed some minor stuff and cleaned some debug outputs.
It seem to work fine, but i only tested on linux with XFCE. The Linux stuff should all be in ifdef, but i am not 100% sure.
Potential problems/stuff nice to have:
Please let me know any other stuff that remains to be done to get this in a mergable state.
Thanks