Skip to content

Add "Number of items answered" metric in the overview table #312

Open

Description

@zkoppert

Is your feature request related to a problem?

When running the action on discussions, it would be nice to be able to see the "Number of items answered" metric in the overview table

Describe the solution you'd like

If discussion is found in the search_query then count the number of discussions marked as answered and display the count in the markdown and json output.

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. github-actions commented on Jul 2, 2024

    @github-actions

    This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

  2. mark-mxwl commented on Feb 16, 2025

    @mark-mxwl

    Hi @zkoppert! I've been reviewing this issue, and would be happy to help out. Before diving in, I'd like to clarify a few things to make sure I fully understand the requirements for the feature:

    1. After reviewing the discussion query schema, I assume that the field to include in the condition is answerChosenAt. Ex.: If the value is not None, add to the count.
    2. I assume that the logic would be implemented in issue_metrics.py, and the following modules would need to be updated to account for the changes: markdown_writer.py, json_writer.py, and any relevant test scripts.
    3. Is there a particular position in the table where you'd like Number of items answered: to appear?

    Any thoughts, suggestions, or guidance you could offer would be greatly appreciated!

  3. Piedone commented on Feb 16, 2025

    @Piedone

    As a user of this action, I'd comment on the 3rd question: I'd add it after "Number of items that remain open", i.e. here:

    Image

    For an example of the current output on an active project see: OrchardCMS/OrchardCore#17442.

  4. mark-mxwl commented on Feb 16, 2025

    @mark-mxwl

    Thanks, @Piedone! Appreciate your input, as well as the sample output. 👌

  5. zkoppert commented on Apr 7, 2025

    @zkoppert
    CollaboratorAuthor

    @mark-mxwl yup that all sounds correct to me and I agree with @Piedone on the placement.

  6. mark-mxwl commented on Apr 8, 2025

    @mark-mxwl

    Thanks for confirming, @zkoppert! I'll ping you when I have a PR up. ⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions