You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add "Number of items answered" metric in the overview table #312
When running the action on discussions, it would be nice to be able to see the "Number of items answered" metric in the overview table
Describe the solution you'd like
If discussion is found in the search_query then count the number of discussions marked as answered and display the count in the markdown and json output.
Hi @zkoppert! I've been reviewing this issue, and would be happy to help out. Before diving in, I'd like to clarify a few things to make sure I fully understand the requirements for the feature:
After reviewing the discussion query schema, I assume that the field to include in the condition is answerChosenAt. Ex.: If the value is not None, add to the count.
I assume that the logic would be implemented in issue_metrics.py, and the following modules would need to be updated to account for the changes: markdown_writer.py, json_writer.py, and any relevant test scripts.
Is there a particular position in the table where you'd like Number of items answered: to appear?
Any thoughts, suggestions, or guidance you could offer would be greatly appreciated!
Activity
github-actions commentedon Jul 2, 2024
This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.
mark-mxwl commentedon Feb 16, 2025
Hi @zkoppert! I've been reviewing this issue, and would be happy to help out. Before diving in, I'd like to clarify a few things to make sure I fully understand the requirements for the feature:
answerChosenAt. Ex.: If the value is notNone, add to the count.issue_metrics.py, and the following modules would need to be updated to account for the changes:markdown_writer.py,json_writer.py, and any relevant test scripts.Number of items answered:to appear?Any thoughts, suggestions, or guidance you could offer would be greatly appreciated!
Piedone commentedon Feb 16, 2025
As a user of this action, I'd comment on the 3rd question: I'd add it after "Number of items that remain open", i.e. here:
For an example of the current output on an active project see: OrchardCMS/OrchardCore#17442.
mark-mxwl commentedon Feb 16, 2025
Thanks, @Piedone! Appreciate your input, as well as the sample output. 👌
zkoppert commentedon Apr 7, 2025
@mark-mxwl yup that all sounds correct to me and I agree with @Piedone on the placement.
mark-mxwl commentedon Apr 8, 2025
Thanks for confirming, @zkoppert! I'll ping you when I have a PR up. ⚡️