Repository navigation
Commit 9b79e81
committed
fix(workflows): let a declared case key keep its literal expression
The guard read the expression text alone, so `expression: inputs.mode` was
rejected even when an `inputs.mode:` case was declared -- a switch that
dispatches that case on every run, because `execute` matches the resolved
value, which for a braceless expression is that very text, stripped, against
`str(case_key)`. Constant, not unevaluated.
`switch_expression_is_never_evaluated` now takes the declared keys and flags a
namespace reference only when none of them declares it, which is the shape that
can do nothing but fall through to `default`. The `{{`-verbatim branch is
unchanged: there the emitted text is not the source text, so a key cannot vouch
for it.
Tests assert `execute` really dispatches the declared case before asserting
`validate` accepts it, then withdraw that one key and require the error back.
Reverting either the predicate or the call site turns the new test red.1 parent 34c6fa9 commit 9b79e81
3 files changed
Lines changed: 90 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
892 | 893 | | |
893 | 894 | | |
894 | 895 | | |
895 | | - | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
896 | 899 | | |
897 | 900 | | |
898 | 901 | | |
| |||
907 | 910 | | |
908 | 911 | | |
909 | 912 | | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
910 | 922 | | |
911 | 923 | | |
912 | 924 | | |
913 | 925 | | |
914 | 926 | | |
915 | 927 | | |
916 | | - | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
917 | 931 | | |
918 | 932 | | |
919 | 933 | | |
| |||
1146 | 1160 | | |
1147 | 1161 | | |
1148 | 1162 | | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
1149 | 1166 | | |
1150 | 1167 | | |
1151 | 1168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
129 | 138 | | |
130 | 139 | | |
131 | 140 | | |
132 | 141 | | |
133 | | - | |
| 142 | + | |
| 143 | + | |
134 | 144 | | |
135 | 145 | | |
136 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3833 | 3833 | | |
3834 | 3834 | | |
3835 | 3835 | | |
| 3836 | + | |
| 3837 | + | |
| 3838 | + | |
| 3839 | + | |
| 3840 | + | |
| 3841 | + | |
| 3842 | + | |
| 3843 | + | |
| 3844 | + | |
| 3845 | + | |
| 3846 | + | |
| 3847 | + | |
| 3848 | + | |
| 3849 | + | |
| 3850 | + | |
| 3851 | + | |
| 3852 | + | |
| 3853 | + | |
| 3854 | + | |
| 3855 | + | |
| 3856 | + | |
| 3857 | + | |
| 3858 | + | |
| 3859 | + | |
| 3860 | + | |
| 3861 | + | |
| 3862 | + | |
| 3863 | + | |
| 3864 | + | |
| 3865 | + | |
| 3866 | + | |
| 3867 | + | |
| 3868 | + | |
| 3869 | + | |
| 3870 | + | |
| 3871 | + | |
| 3872 | + | |
| 3873 | + | |
| 3874 | + | |
| 3875 | + | |
| 3876 | + | |
| 3877 | + | |
| 3878 | + | |
| 3879 | + | |
| 3880 | + | |
| 3881 | + | |
| 3882 | + | |
| 3883 | + | |
| 3884 | + | |
| 3885 | + | |
| 3886 | + | |
| 3887 | + | |
| 3888 | + | |
| 3889 | + | |
| 3890 | + | |
| 3891 | + | |
| 3892 | + | |
| 3893 | + | |
| 3894 | + | |
3836 | 3895 | | |
3837 | 3896 | | |
3838 | 3897 | | |
| |||
0 commit comments