Repository navigation
Commit 86606ef
fix: address Copilot review feedback for config scaffolding
- Validate manifest config shape (reject non-list/non-dict entries)
- Add path traversal protection (reject .. segments and absolute paths)
- Use is_file() check instead of exists() to reject directory templates
- Return (deployed, skipped) tuple for richer CLI messaging
- Add security tests for path traversal and directory rejection
- Add test for malformed manifest config sections
Co-Authored-By: Claude Opus 4.6 <[email protected]>1 parent 3efbaf3 commit 86606ef
3 files changed
Lines changed: 89 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3667 | 3667 | | |
3668 | 3668 | | |
3669 | 3669 | | |
3670 | | - | |
| 3670 | + | |
3671 | 3671 | | |
3672 | 3672 | | |
3673 | 3673 | | |
3674 | 3674 | | |
3675 | | - | |
3676 | | - | |
| 3675 | + | |
| 3676 | + | |
3677 | 3677 | | |
3678 | 3678 | | |
3679 | 3679 | | |
| |||
4477 | 4477 | | |
4478 | 4478 | | |
4479 | 4479 | | |
4480 | | - | |
| 4480 | + | |
4481 | 4481 | | |
4482 | 4482 | | |
4483 | 4483 | | |
4484 | 4484 | | |
| 4485 | + | |
| 4486 | + | |
4485 | 4487 | | |
4486 | 4488 | | |
4487 | 4489 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
240 | 243 | | |
241 | 244 | | |
242 | 245 | | |
| |||
1130 | 1133 | | |
1131 | 1134 | | |
1132 | 1135 | | |
1133 | | - | |
| 1136 | + | |
1134 | 1137 | | |
1135 | 1138 | | |
1136 | 1139 | | |
| |||
1141 | 1144 | | |
1142 | 1145 | | |
1143 | 1146 | | |
1144 | | - | |
| 1147 | + | |
| 1148 | + | |
1145 | 1149 | | |
1146 | 1150 | | |
1147 | 1151 | | |
| |||
1151 | 1155 | | |
1152 | 1156 | | |
1153 | 1157 | | |
| 1158 | + | |
| 1159 | + | |
1154 | 1160 | | |
1155 | 1161 | | |
1156 | 1162 | | |
1157 | 1163 | | |
1158 | 1164 | | |
1159 | 1165 | | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
1160 | 1172 | | |
1161 | | - | |
| 1173 | + | |
1162 | 1174 | | |
1163 | 1175 | | |
1164 | 1176 | | |
1165 | 1177 | | |
1166 | | - | |
| 1178 | + | |
1167 | 1179 | | |
1168 | 1180 | | |
1169 | 1181 | | |
1170 | 1182 | | |
1171 | 1183 | | |
1172 | 1184 | | |
1173 | | - | |
| 1185 | + | |
1174 | 1186 | | |
1175 | 1187 | | |
1176 | 1188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
885 | 885 | | |
886 | 886 | | |
887 | 887 | | |
888 | | - | |
| 888 | + | |
889 | 889 | | |
890 | 890 | | |
| 891 | + | |
891 | 892 | | |
892 | 893 | | |
893 | 894 | | |
| |||
908 | 909 | | |
909 | 910 | | |
910 | 911 | | |
911 | | - | |
| 912 | + | |
912 | 913 | | |
913 | 914 | | |
| 915 | + | |
914 | 916 | | |
915 | 917 | | |
916 | 918 | | |
| |||
923 | 925 | | |
924 | 926 | | |
925 | 927 | | |
926 | | - | |
| 928 | + | |
927 | 929 | | |
928 | 930 | | |
| 931 | + | |
929 | 932 | | |
930 | 933 | | |
931 | 934 | | |
| |||
941 | 944 | | |
942 | 945 | | |
943 | 946 | | |
944 | | - | |
| 947 | + | |
945 | 948 | | |
946 | 949 | | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
947 | 1008 | | |
948 | 1009 | | |
949 | 1010 | | |
| |||
0 commit comments