Skip to content

Commit 6e2d81d

Browse files
mnriemCopilot
andcommitted
refactor(extensions): remove before_specify hook from assess
Assess is a separate business process from spec-driven development, so it should not inject itself into the /speckit.specify lifecycle. The hook fired on every /speckit.specify invocation (it had no condition), nagging even when an assessment already existed and the user was deliberately proceeding. Unlike git's before_specify (a mechanical prerequisite: create a feature branch) or agent-context's after_* hooks (reacting to spec output), assess is an upstream, optional, human-judgment process. The coupling that belongs here already runs forward and by choice: a `go` verdict from /speckit.assess.decide hands off to /speckit.specify. The backward hook was the redundant, intrusive direction. - extension.yml: drop the hooks block (commands-only manifest) - README.md: replace the Hooks section with a Handoff section - test: replace the hook assertion with test_declares_no_hooks to lock in the standalone-pipeline design Assisted-by: GitHub Copilot (model: Claude Opus 4.8, supervised) Co-authored-by: Copilot App <[email protected]> Copilot-Session: 1f25cf9d-b7eb-4b2b-b811-3e91d8db8f6a
1 parent 4c8124d commit 6e2d81d

3 files changed

Lines changed: 8 additions & 15 deletions

File tree

‎extensions/assess/README.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,9 @@ specify extension enable assess
8585
# → on "go", hand the decision.md handoff summary to /speckit.specify
8686
```
8787

88-
## Hooks
88+
## Handoff
8989

90-
Registers one **optional** hook:
91-
92-
- `before_specify` → prompts `speckit.assess.intake` — a nudge to assess an idea before committing it to a specification. It never runs automatically; the user chooses.
90+
`assess` is a **standalone pipeline you enter deliberately** — it registers no lifecycle hooks and never inserts itself into `/speckit.specify`. The only coupling runs forward and by choice: a `go` verdict from `/speckit.assess.decide` hands its `decision.md` summary to `/speckit.specify`. Discovery and specification stay separate processes.
9391

9492
## Guardrails
9593

‎extensions/assess/extension.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,6 @@ provides:
3232
file: commands/speckit.assess.decide.md
3333
description: "Apply a go / needs-clarification / kill gate and hand survivors off to /speckit.specify"
3434

35-
hooks:
36-
before_specify:
37-
command: speckit.assess.intake
38-
optional: true
39-
prompt: "Assess this idea before specifying?"
40-
description: "Nudge to assess an idea before committing it to a specification"
41-
4235
tags:
4336
- "assessment"
4437
- "discovery"

‎tests/extensions/assess/test_assess_extension.py‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@ def test_extension_yml_has_required_fields(self):
4848
commands = {c["name"] for c in manifest["provides"]["commands"]}
4949
assert commands == EXPECTED_COMMANDS
5050

51-
def test_before_specify_hook_is_optional(self):
51+
def test_declares_no_hooks(self):
52+
"""assess is a standalone pipeline: it must not register lifecycle
53+
hooks (e.g. before_specify). Discovery and specification stay
54+
separate processes; the only coupling is the forward decide ->
55+
/speckit.specify handoff described in the commands."""
5256
manifest = yaml.safe_load(
5357
(EXT_DIR / "extension.yml").read_text(encoding="utf-8")
5458
)
55-
hook = manifest["hooks"]["before_specify"]
56-
assert hook["optional"] is True
57-
assert hook["command"] == "speckit.assess.intake"
59+
assert "hooks" not in manifest or not manifest["hooks"]
5860

5961
def test_readme_exists(self):
6062
readme = EXT_DIR / "README.md"

0 commit comments

Comments
 (0)