Merged
Conversation
williammartin
force-pushed
the
wm/bump-mcp-go
branch
from
2d3a147 to
40897fc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mcp-go dependency to v0.30.0 and refactors all direct accesses of r.Params.Arguments to the new r.GetArguments() API.
- Swapped
r.Params.Arguments[...]withr.GetArguments()[...]across server, repository, and issue handlers. - Updated the test helper
createMCPRequestsignature to accept a genericanyarguments payload. - Bumped
github.com/mark3labs/mcp-goto v0.30.0 ingo.mod.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/server.go | Replaced r.Params.Arguments with r.GetArguments() in all helpers. |
| pkg/github/repositories.go | Updated argument access in PushFiles to use GetArguments(). |
| pkg/github/issues.go | Changed pagination params to use GetArguments(). |
| pkg/github/helper_test.go | Adjusted createMCPRequest to take any for Arguments. |
| go.mod | Bumped github.com/mark3labs/mcp-go from v0.28.0 to v0.30.0. |
SamMorrowDrums
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
mcp-goto 0.30.0.There is a breaking change introduced by mark3labs/mcp-go#287. While there are now better patterns, this PR is the simplest path to bump.
E2E tests