Import Emoji 14.0 characters #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May as well update this to Unicode 15 sometime. |
Contributor
|
@novacrazy After Unicode 15 widely ships on devices like smartphones will be the right time to add them to this project. 🙇 |
Closed
|
Out of curiosity, what is the source of these? Tags, aliases, etc. |
Contributor
|
We mostly generate initial aliases from the character descriptions in the Unicode spec. Sometimes we just straight-up invent aliases (for the most common emoji). Tags we add at our own discretion to aid searching in emoji pickers that use this library. |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Jan 4, 2023
Gitea emoji dataset was out of date because it gets manually build and hasn't been rebuilt since it was added. This means Gitea doesn't recognize some newer emoji or changes to existing ones. After changing the max unicode version to 14 I just ran: `go run build/generate-emoji.go` This should address the initial issue seen in go-gitea#22153 where Gitea doesn't recognize a standard alias used elsewhere when importing content. 14 is the latest supported version from the upstream source as 15 is not widely supported (in their opinion) yet: github/gemoji#244 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://emojipedia.org/emoji-14.0/
The iOS version where these emojis are added is 15.4 (source).
This solves #237