Skip to content

Skip hosts API #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meiji163 merged 6 commits into from
Sep 23, 2022
Merged

Skip hosts API #149

meiji163 merged 6 commits into from
Sep 23, 2022

Conversation

@meiji163
Copy link
Contributor

@meiji163 meiji163 commented Sep 21, 2022 •
edited
Loading

adds GET endpoints from #28 for skipping hosts dyanmically
/skip-host/:hostName
/skip-host/:hostName/ttl/:ttlMinutes
/skipped-hosts
/recover-host/:hostName

Implemented for raft and mysql backends. For MySQL backend it requires new table

CREATE TABLE skipped_hosts (
   host_name varchar(128) NOT NULL,
   skipped_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
   expires_at TIMESTAMP NOT NULL,
   PRIMARY KEY (host_name)
);

closes #28

@meiji163 meiji163 changed the title add skip hosts with raft storage Skip hosts Sep 21, 2022
@meiji163 meiji163 marked this pull request as ready for review September 21, 2022 23:30
@meiji163
Copy link
Contributor Author

meiji163 commented Sep 22, 2022

I tested the basic functionality works in staging for MySQL backend and raft single-node setup

ghost
ghost approved these changes Sep 22, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@meiji163 meiji163 temporarily deployed to staging September 23, 2022 15:28 Inactive
@meiji163 meiji163 changed the title Skip hosts Skip hosts API Sep 23, 2022
@meiji163 meiji163 temporarily deployed to production September 23, 2022 16:09 Inactive
@meiji163 meiji163 merged commit d3070dc into master Sep 23, 2022
@meiji163 meiji163 deleted the meiji163/skip-host branch September 23, 2022 22:47
@meiji163 meiji163 mentioned this pull request Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Be able to ignore a specific host

2 participants

@meiji163