Skip to content

Vitess: handle non-200 HTTP status in ParseTablets() #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timvaillancourt merged 2 commits into from
Jul 23, 2020
Merged

Vitess: handle non-200 HTTP status in ParseTablets() #125

timvaillancourt merged 2 commits into from
Jul 23, 2020

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Jul 23, 2020 •
edited
Loading

This PR fixes a strange error when a Vitess API returns a 404 Not Found for a missing keyspace:

2020-07-22 13:34:06 ERROR Unable to get vitess hosts from https://<hostname>/api, <keyspace>/: invalid character 'p' after top-level value

Now the HTTP status line is returned as an error unless a 200 OK is returned

Base automatically changed from vitess-cell-support to master July 23, 2020 10:22
@timvaillancourt timvaillancourt temporarily deployed to staging July 23, 2020 16:37 Inactive
@timvaillancourt timvaillancourt merged commit 5de5f0d into master Jul 23, 2020
@timvaillancourt timvaillancourt deleted the vitess-handle-http404 branch July 23, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drogart drogart drogart approved these changes

@tomkrouper tomkrouper Awaiting requested review from tomkrouper

@gtowey gtowey Awaiting requested review from gtowey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timvaillancourt @drogart