fix: stop svg-element-attributes v2.0.0 from installing#118
Merged
koddsson merged 3 commits intogithub:mainfrom Mar 31, 2021
andykenward:svg-element-attributes
Merged
fix: stop svg-element-attributes v2.0.0 from installing#118koddsson merged 3 commits intogithub:mainfrom andykenward:svg-element-attributes
koddsson merged 3 commits intogithub:mainfrom
andykenward:svg-element-attributes
Conversation
When using the package in a new project svg-element-attributes v2.0.0 is installed causing eslint to error with “ES module” Signed-off-by: Andy Kenward <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the package in a new project
svg-element-attributesv2.0.0is installed causing eslint to error with the below error. This is becausesvg-element-attributesv2.0.0is ESM only and must useimportinstead ofrequirewhen using.Doing a
npm i -D svg-element-attributes@^1.3.1to the new project solves the issue.I suggest changing the semver version of svg-element-attributes from
>=1.3.1to^1.3.1. To avoid users of this package from having this issue.node v14.16.0npm 6.14.12Signed-off-by: Andy Kenward [email protected]