Skip to content

Drop verbose from cp call#34015

Merged
subatoi merged 2 commits intogithub:mainfrom
WyriHaximus:patch-2
Jul 25, 2024
Merged

Drop verbose from cp call#34015
subatoi merged 2 commits intogithub:mainfrom
WyriHaximus:patch-2

Conversation

@WyriHaximus
Copy link
Copy Markdown
Contributor

@WyriHaximus WyriHaximus commented Jul 18, 2024

Why:

Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.

What's being changed (if available, include any code snippets, screenshots, or gifs):

The cp call in the init-dind-externals init container examples.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 18, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 18, 2024
@nguyenalex836
Copy link
Copy Markdown
Contributor

@WyriHaximus Thanks so much for opening a PR! I'll get this triaged for review ✨

@WyriHaximus
Copy link
Copy Markdown
Contributor Author

@nguyenalex836 cool, let me know if I need to provide some numbers or anything else on this 👍.

Copy link
Copy Markdown
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WyriHaximus — I agree with you. Thanks for raising a PR for this change, I'll go ahead and approve and merge it!

@github-actions
Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@subatoi subatoi added this pull request to the merge queue Jul 25, 2024
Merged via the queue into github:main with commit 11eda7e Jul 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@WyriHaximus WyriHaximus deleted the patch-2 branch July 26, 2024 11:31
@WyriHaximus
Copy link
Copy Markdown
Contributor Author

@subatoi cheers!

WyriHaximus added a commit to WyriHaximus-labs/actions-runner-controller that referenced this pull request Nov 11, 2024
This follows up github/docs#34015 and resolves the issue brought up in actions#3637

As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
WyriHaximus added a commit to WyriHaximus-labs/actions-runner-controller that referenced this pull request Nov 15, 2024
This follows up github/docs#34015 and resolves the issue brought up in actions#3637

As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
WyriHaximus added a commit to WyriHaximus-labs/actions-runner-controller that referenced this pull request Mar 5, 2025
This follows up github/docs#34015 and resolves the issue brought up in actions#3637

As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants