Conversation
Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
|
@WyriHaximus Thanks so much for opening a PR! I'll get this triaged for review ✨ |
|
@nguyenalex836 cool, let me know if I need to provide some numbers or anything else on this 👍. |
subatoi
left a comment
There was a problem hiding this comment.
Hi @WyriHaximus — I agree with you. Thanks for raising a PR for this change, I'll go ahead and approve and merge it!
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
|
@subatoi cheers! |
This follows up github/docs#34015 and resolves the issue brought up in actions#3637 As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
This follows up github/docs#34015 and resolves the issue brought up in actions#3637 As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
This follows up github/docs#34015 and resolves the issue brought up in actions#3637 As mentioned in the docs PR as well: Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
Why:
Having the verbose flag in there is nice for debugging but it logs a ton of mostly information that isn't interesting most of the time. Plus is slows the cp call down having to output it all. It shouldn't be the default recommended way to run it as such.
What's being changed (if available, include any code snippets, screenshots, or gifs):
The
cpcall in theinit-dind-externalsinit container examples.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.