Skip to content

Conversation

@aeisenberg
Copy link
Contributor

Some instructions on how to update required checks. I hope we can fully automate this soon, and these instructions will help.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner March 8, 2022 02:39
@aeisenberg aeisenberg requested review from cklin and henrymercer March 8, 2022 02:39
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a better place for these instructions! Couple of suggestions.

@aeisenberg aeisenberg force-pushed the aeisenberg/required-checks branch from 6ddde1d to 111428c Compare March 8, 2022 18:19
@aeisenberg aeisenberg requested review from cklin and henrymercer March 8, 2022 18:19
@aeisenberg
Copy link
Contributor Author

I made some changes based on @henrymercer's suggestions. It is much simpler now and it's now possible to convert this into an automated action more easily.

@aeisenberg aeisenberg enabled auto-merge March 10, 2022 17:20
@henrymercer henrymercer disabled auto-merge March 11, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants