Skip to content

fix: persist inputs between the upload action and its post step #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NlightNFotis merged 6 commits into from
Oct 21, 2024
Merged

fix: persist inputs between the upload action and its post step #2557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6026274
Persist inputs between the upload action and its post step.
chrisgavin Oct 21, 2024
2a8a5cc
chore: add changelog for input persistence
NlightNFotis Oct 21, 2024
bd02c19
feat: patch start-proxy-action, analyze-action and init-action as well
NlightNFotis Oct 21, 2024
0c7697c
Remove trailing whitespace from CHANGELOG
jsoref Oct 20, 2024
cdceebc
build: refresh js files
NlightNFotis Oct 21, 2024
9bc4ee1
review-comments: add more descriptive comments to various persist/res…
NlightNFotis Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review-comments: add more descriptive comments to various persist/res… 
…toreState callsites.

Co-authored-by: Henry Mercer <[email protected]>
Co-authored-by: Fotis Koutoulakis <[email protected]>
  • Loading branch information
@NlightNFotis @henrymercer
NlightNFotis and henrymercer committed Oct 21, 2024
commit 9bc4ee10c713bbc8079d7b95c5708e7820201d70
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
## [UNRELEASED]

- Bump the minimum CodeQL bundle version to 2.14.6. [#2549](https://github.com/github/codeql-action/pull/2549)
- The upload-sarif action should not break composite actions that have a different set of inputs than the ones expected by upload-sarif. Failure used to appear in the form of: `upload-sarif post-action step failed: Input required and not supplied: token`.
- Fix an issue where the `upload-sarif` Action would fail with "upload-sarif post-action step failed: Input required and not supplied: token" when called in a composite Action that had a different set of inputs to the ones expected by the `upload-sarif` Action. [#2557](https://github.com/github/codeql-action/pull/2557)

## 3.26.13 - 14 Oct 2024

Expand Down
2 changes: 1 addition & 1 deletion lib/actions-util.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions lib/init-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/init-action-post.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading