update release process to support multiple version #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
reviewed
Dec 5, 2023
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Looks good! My main comment is around what happens the first time we backport a new major version of the Action.
henrymercer
approved these changes
Dec 6, 2023
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Excellent, thanks for addressing my comments!
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR udpates the release process in order to handle maintaining multiple versions. To a large extent this reintroduces the logic removed in...
...but adapted in order to avoid hardcoding version numbers. The process should also support maintaining two or more older version of the action, should that ever be required.
The process to release a new version will now be to first bump the major version number and merge that PR to
main. Then run theupdate-release-branch.ymlworkflow, which will...releases/vNewbranchmainupdate-release-branch.ymlwill be triggered again, this time opening mergeback PRs againstfrom releases/vLatestto all previous supported release branchesupdate-release-branch.ymlworkflow will also run, updating the tags forvLatestas required and if the release branch is the latest one then also opening a backport PR tomainNote that both these workflows will also be triggered when mergeback PRs are merged against older release branches, but in this case
update-release-branch.ymlwill take no action andupdate-release-branch.ymlwill run only the operations to ensure tags for the relevant version are up to date.Retiring older versions is now a matter of updating
OLDEST_SUPPORTED_MAJOR_VERSIONinrelease-branches.py, see the new section inCONTRIBUTING.mdfor details.NB The changes in this PR have been tested in a private fork of the repository.
Merge / deployment checklist