C++: add deptrace pr-checks #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
force-pushed
the
redsun82/cpp-deptrace-pr-checks
branch
from
9c3ff35 to
d53a59d
Compare
henrymercer
reviewed
Oct 25, 2023
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Nice! Minor comments and suggestions for clarity, but this looks good!
Co-authored-by: Henry Mercer <[email protected]>
henrymercer
approved these changes
Oct 25, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist