Skip to content

Use the correct action input parameter #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aeisenberg merged 5 commits into from
Nov 2, 2023
Merged

Use the correct action input parameter #1963

aeisenberg merged 5 commits into from
Nov 2, 2023

Conversation

@aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Oct 20, 2023 •
edited
Loading

Fixes an integration test that isn't quite testing what we think it is.

Also, ensures that all macos tests run on python 3.11. See separate commits.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner October 20, 2023 23:15
@aeisenberg aeisenberg force-pushed the aeisenberg/fix-source-root branch from ceb945c to 415bca9 Compare October 20, 2023 23:18
@angelapwen
Copy link
Contributor

angelapwen commented Oct 20, 2023

Looks like we're not allowed to remove the current directory in Actions.

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Oct 21, 2023

When I get a chance, I'll selectively remove a few key directories to ensure we're not accidentally using them.

@aeisenberg aeisenberg force-pushed the aeisenberg/fix-source-root branch 6 times, most recently from 6eb467f to 2819bc4 Compare November 1, 2023 00:11
@aeisenberg aeisenberg force-pushed the aeisenberg/fix-source-root branch from 2819bc4 to da4c460 Compare November 1, 2023 00:16
@aeisenberg aeisenberg requested a review from angelapwen November 1, 2023 00:16
@aeisenberg
Copy link
Contributor Author

aeisenberg commented Nov 1, 2023

@angelapwen can you take another look? I think this should work now.

angelapwen
angelapwen previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, but we'll need to fix the Python 3.12 issue causing the tests to fail separately.

@angelapwen
Copy link
Contributor

angelapwen commented Nov 1, 2023

Re-ran and we got an older version of the runner so PR checks have passed 👍

@aeisenberg aeisenberg force-pushed the aeisenberg/fix-source-root branch from 108033a to 8948a7c Compare November 1, 2023 22:50
@aeisenberg
Force python 3.11 for macos
bd4005a 
3.12 does not work.
@aeisenberg aeisenberg force-pushed the aeisenberg/fix-source-root branch from 8948a7c to bd4005a Compare November 1, 2023 23:01
angelapwen
angelapwen previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! I guess at some point this runner image will stop being macos-latest but looks good for now.

@aeisenberg
Be more precise about when to use python 3.11
9ef69a2 
Only run use 3.11 on versions of of the CLI that we know don't support
3.12.
@aeisenberg
Copy link
Contributor Author

aeisenberg commented Nov 2, 2023

Updated to only apply python 3.11 for older CLIs. At some point, we can purge references to CLIs we no longer support, but that can happen at some point in the future.

henrymercer
henrymercer previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple of non-blocking suggestions.

@aeisenberg aeisenberg enabled auto-merge November 2, 2023 14:53
auto-merge was automatically disabled November 2, 2023 14:56

Pull Request is not mergeable

@aeisenberg aeisenberg enabled auto-merge November 2, 2023 15:04
@aeisenberg aeisenberg merged commit 137a1e0 into main Nov 2, 2023
@aeisenberg aeisenberg deleted the aeisenberg/fix-source-root branch November 2, 2023 15:18
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

+1 more reviewer

@angelapwen angelapwen angelapwen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aeisenberg @angelapwen @henrymercer