Add commit sha to database upload #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/database-upload.ts
Outdated
| ); | ||
| try { | ||
| await client.request( | ||
| `POST https://uploads.github.com/repos/:owner/:repo/code-scanning/codeql/databases/:language?name=:name`, |
Contributor
There was a problem hiding this comment.
Suggested change
| `POST https://uploads.github.com/repos/:owner/:repo/code-scanning/codeql/databases/:language?name=:name`, | |
| `POST https://uploads.github.com/repos/:owner/:repo/code-scanning/codeql/databases/:language?name=:name&commit_oid=:commit_oid`, |
Oops, I missed we'll need to include commit_oid here so that it knows how to include it when making the HTTP request. The body of the request is just the database contents, so the commit oid needs to be included as a URL param.
Contributor
Author
There was a problem hiding this comment.
lol makes sense 🤦♀️
norascheuch
force-pushed
the
nora/add-commit-sha-to-database-upload
branch
from
1677e55 to
aed2e7f
Compare
norascheuch
force-pushed
the
nora/add-commit-sha-to-database-upload
branch
from
3d409d1 to
7273335
Compare
norascheuch
force-pushed
the
nora/add-commit-sha-to-database-upload
branch
from
7273335 to
e62d946
Compare
Contributor
|
Code LGTM, but this shouldn't be merged until we've merged the API change and then tested this PR. |
robertbrignull
approved these changes
Oct 12, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist
This PR adds the commit_oid to the database upload, so that users know - when using the database later - which version of the code it is based on.