Skip to content

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Jul 6, 2023

Add a deprecation warning for customers using the now deprecated 2.8.6–2.9.3 range of CLIs that these CLIs will not be supported by the next version of the Action:

image

In the future, we can integrate this into our GHES compatibility automation to automatically add deprecation warnings once a CLI is deprecated.

Commit-by-commit review recommended, as the second commit refactors how we represent environment variables in the Action.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner July 6, 2023 16:17
@henrymercer henrymercer force-pushed the henrymercer/cli-deprecation-warning branch from 954533d to f0f15c9 Compare July 6, 2023 16:29
@henrymercer henrymercer force-pushed the henrymercer/cli-deprecation-warning branch from f0f15c9 to 674e180 Compare July 6, 2023 16:37
angelapwen
angelapwen previously approved these changes Jul 7, 2023
angelapwen
angelapwen previously approved these changes Jul 7, 2023
@henrymercer henrymercer enabled auto-merge July 7, 2023 12:15
@henrymercer henrymercer merged commit 395fdba into main Jul 7, 2023
@henrymercer henrymercer deleted the henrymercer/cli-deprecation-warning branch July 7, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants