PR checks: Update requests to 2.31.0 #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/update-requests
branch
from
66e535c to
6e92b19
Compare
Contributor
Author
|
Debug artifact upload failures fixed by #1696. |
yoff
approved these changes
May 26, 2023
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
LGTM
(nit: It would have been nice to split the first commit in two so the rewriting of the files was clear from the diff and the moving happened separately.)
Contributor
Author
|
Thanks, that's good feedback. I had hoped that the diff would recognize the change as a rename! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
requeststo 2.31.0 to address GHSA-j8r2-6x86-q33q. We don't use this in the Action itself, but instead in PR checks that test Python dependency installation.@github/codeql-python I'd appreciate it if one of you could take a careful look at this PR to make sure I've preserved test coverage. Thanks!
Merge / deployment checklist