Fix the bundleVersion field set by the automated bundle update PR
#1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the whole tag, we don't want to remove the `codeql-bundle-` prefix.
angelapwen
approved these changes
Apr 18, 2023
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
🤔 how long has this been broken for? 😬
Contributor
Author
|
Not long — 2.12.7 was the first automated bundle upgrade PR, since the trigger wasn't working for 2.13.0 (#1648). Hopefully we're over the teething pains now! |
Contributor
💡 that'll do it! Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bundleVersionis the whole tag, we don't want to remove thecodeql-bundle-prefix.Commit-by-commit review recommended since we autoformat the update bundle Action in the second commit.
Merge / deployment checklist