Skip to content

Add telemetry for uploading failed runs #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrymercer merged 6 commits into from
Dec 12, 2022
Merged

Add telemetry for uploading failed runs #1432

henrymercer merged 6 commits into from
Dec 12, 2022

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Dec 9, 2022 •
edited
Loading

#1393 started uploading failed runs to the code scanning API. In preparation for rolling this out, it would be useful to gather some telemetry, particularly since things are set up to be unlikely to hard-fail, so we probably won't get any customer feedback.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner December 9, 2022 11:59
aeisenberg
aeisenberg reviewed Dec 9, 2022
View reviewed changes
angelapwen
angelapwen reviewed Dec 12, 2022
View reviewed changes
angelapwen
angelapwen reviewed Dec 12, 2022
View reviewed changes
angelapwen
angelapwen approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@henrymercer henrymercer merged commit 899bf9c into main Dec 12, 2022
@henrymercer henrymercer deleted the henrymercer/init-post-telemetry branch December 12, 2022 18:45
This was referenced Dec 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg Awaiting requested review from aeisenberg

1 more reviewer

@angelapwen angelapwen angelapwen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henrymercer @aeisenberg @angelapwen